74920[DOCS] Document "Restrict export functionality"
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Chris Müller +1
- Oliver Hader +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Chris Müller +1
- core-ci +1 CI
Issues 1
Files 3
- typo3/sysext/core/Documentation/Changelog/10.4.x/Important-94951-RestrictExportFunctionalityToAllowedUsers.rstnew+53 −0
- typo3/sysext/core/Documentation/Changelog/11.5.x/Important-94951-RestrictExportFunctionalityToAllowedUsers.rstnew+53 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Important-94951-RestrictExportFunctionalityToAllowedUsers.rst2new+53 −0
Review log 2633
Show 68 earlier messages
-
Lina Wolf uploaded patch set 1 06/16/22, 09:48
-
Lina Wolf updated the commit message in patch set 2 06/16/22, 09:48
-
core-ci voted on patch set 2 V +1 06/16/22, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28113
-
core-ci voted on patch set 1 V +1 06/16/22, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28112
-
Oliver Hader commented on patch set 2 06/16/22, 10:16
It think we only put that to the older version, which would be `10.4.x` in this case. Otherwise it would require an item for `12.0` as well - just to be consequent here. -
Chris Müller commented on patch set 2 06/16/22, 12:00
Breaking-94951-RestrictExportFunctionalityToAllowedUsers.rst:25I would prefer linking directly to the security advisory instead of the overall article: https://typo3.org/security/advisory/typo3-core-sa-2022-001 as the news article provides no additional value to the user for this case. -
Lina Wolf uploaded patch set 3 06/16/22, 16:43
-
Lina Wolf commented on patch set 3 06/16/22, 16:44
Reply
Well here the exact case is mentioned and it is written we do it like that. I think the reason is that none is using 12.0 yet. https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/Howto.html#locationBreaking-94951-RestrictExportFunctionalityToAllowedUsers.rst:25ReplyDone
-
core-ci voted on patch set 3 V +1 06/16/22, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28116
-
Chris Müller commented on patch set 3 CR -1 06/16/22, 17:42
Breaking-94951-RestrictExportFunctionalityToAllowedUsers.rst:25ReplyBut only in the 11.5 branch. -
Stefan Bürk commented on patch set 3 06/16/22, 20:22
Would suggest to change this to `https://review.typo3.org/c/Packages/TYPO3.CMS/+/74902`. Otherwise clicking on it in gerrit (even later) will lead to a 404 in redmine/forge. -
Chris Müller commented on patch set 3 06/17/22, 11:46
Another issue occurs: a breaking changelog is not listed in 11.x folder, as per definition, there should be no breakings in an LTS release ;-) This states the note at the beginning. So, either we have to add a breaking TOC in the Index.rst or we declare it as important (which I would prefer). -
Chris Müller commented on patch set 3 06/19/22, 13:33
Breaking-94951-RestrictExportFunctionalityToAllowedUsers.rst:3Another one: This anchor is the same as in 11.5.x. I assume this will collide? -
Lina Wolf updated the commit message in patch set 4 06/21/22, 06:34
-
Lina Wolf commented on patch set 4 06/21/22, 06:38
Reply
Done -
core-ci voted on patch set 4 V +1 06/21/22, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28289
-
Lina Wolf uploaded patch set 5 06/22/22, 06:41
-
core-ci voted on patch set 5 V +1 06/22/22, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28325
-
Lina Wolf uploaded patch set 6 06/22/22, 06:57
-
Lina Wolf commented on patch set 6 06/22/22, 06:59
Reply
I checked it, yes, it should be added to 12.0 as well, I will have to update the explainaition in the Howto in another ticketReply
I added it now. Security changes maybe and often are breaking by default. That is why I added it together with an explaination why a breaking change was introduced.Breaking-94951-RestrictExportFunctionalityToAllowedUsers.rst:3ReplyYeah right, I changed itBreaking-94951-RestrictExportFunctionalityToAllowedUsers.rst:25ReplyYeah, you are right, applied it to both now -
Lina Wolf commented on patch set 6 06/22/22, 06:59
Reply
-
core-ci voted on patch set 6 V +1 06/22/22, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28326
-
Chris Müller voted on patch set 6 V +1 CR +1 06/22/22, 07:31
-
Oliver Hader commented on patch set 6 06/22/22, 07:40
I'd still suggest to go with "Important" changes, like it has been done before - e.g. https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/9.5.x/Index.html With using "Breaking" we just create another superfluous discussion on a too generalized and too broad topic... -
Lina Wolf commented on patch set 6 06/22/22, 08:17
Breaking-94951-RestrictExportFunctionalityToAllowedUsers.rst:3ReplyDone -
Lina Wolf uploaded patch set 7 06/22/22, 08:23
-
Oliver Hader voted on patch set 7 CR +1 06/22/22, 08:25
-
core-ci voted on patch set 7 V +1 06/22/22, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28328
-
Chris Müller voted on patch set 7 V +1 CR +1 06/22/22, 13:55
-
Nikita Hovratov commented on patch set 7 06/23/22, 18:56
Important-94951-RestrictExportFunctionalityToAllowedUsers.rst:49Shouldn't this be indented with 3 spaces? It works nevertheless, though. -
Nikita Hovratov commented on patch set 7 V +1 CR +1 06/23/22, 19:27
Important-94951-RestrictExportFunctionalityToAllowedUsers.rst:49ReplyDone -
Nikita Hovratov voted on patch set 7 V +2 CR +2 06/23/22, 19:33
-
Nikita Hovratov merged patch set 8 06/23/22, 19:34