Review main Merged

74928[BUGFIX] Toggle inline controls only in own scope

Nikita Hovratov CR +2 V +2 Easy +12 −6 updated 08/12/22, 22:06

Commit message

The former approach in #91808 to fix scoped toggling didn't
work with levelLinksPosition "bottom", as the querySelector
could find another control container inside another child
inline field first.

Another solution, which is now possible, works with the
":scope" selector. Only nodes with a direct parent will be
found this way.

In addition, a new helper class is added for the top control
container, as it is wrapped in another div. This enables
toggling of both buttons, in case levelLinksPosition "both"
is set.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 3