Review 11.5 Merged

74943[TASK] Clarify docblock for addPlugin

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 06/30/22, 04:18

Commit message

Clarify in the docblock that it is also possible to pass an icon
identifier to addPlugin, not just an icon path.

The first argument of the method ExtensionManagementUtility::addPlugin()
expects an array. The possible values are explained in the docblock. For
the third value, the icon, it is possible to pass a path or an icon
identifier.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 06/30/22, 04:08

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/30/22, 04:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28518

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 06/30/22, 04:18

  4. Stefan Bürk merged patch set 2 06/30/22, 04:18