Review main Merged

74967[TASK] Add exception message to log message

Georg Ringer CR +2 V +2 Easy +1 −1 updated 08/12/22, 20:57

Commit message

Providing the exception message helps to understand and solve the
issue as the exception can also be thrown by a 3rd party extension.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Jörg Bösche +1
    • Felix P. +1
    • Stefan Froemken +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Felix P. +1
    • Stefan Froemken +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 06/21/22, 05:04

  2. Georg Ringer commented on patch set 1 06/21/22, 05:04

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 06/21/22, 05:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28287

  4. core-ci voted on patch set 1 V +1 06/21/22, 05:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28287

  5. Simon Schaufelberger voted on patch set 1 V +1 CR +1 06/21/22, 07:42

  6. Jörg Bösche voted on patch set 1 CR +1 06/23/22, 13:42

  7. Oliver Klee voted on patch set 1 CR +1 06/23/22, 13:59

  8. Felix P. voted on patch set 1 V +1 CR +1 06/24/22, 14:14

  9. Stefan Froemken voted on patch set 1 V +1 CR +1 08/05/22, 20:21

  10. Christian Kuhn commented on patch set 1 V +1 CR +1 08/12/22, 20:56

    the real issue is here that \RuntimeException shouldn't be caught at all, but should bubble up to core exception handler. however, fal has a bad history of throwing 'global' exception that are expected to be caught by upper level code, and this is nothing we can change in a bugfix. as such, that change is ok for now, but 'catch \Exception' or a direct inheritance of that is bad practice and the last usages of that should vanish.
  11. Stefan Bürk voted on patch set 1 V +2 CR +2 08/12/22, 20:57

  12. Stefan Bürk merged patch set 2 08/12/22, 20:57