Review 10.4 Merged

74975[BUGFIX] Fix page link in redirects module bottom pagination

Martin Tepper CR +2 V +2 Easy +4 −5 updated 07/07/22, 16:30

Commit message

With this patch, the page link (requesting a dedicated
paginated page) in the redirects module bottom pagination
is now working again. This is done by selecting all pagination
forms and adding the submit event to them.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Martin Tepper uploaded patch set 1 06/23/22, 12:38

  2. core-ci voted on patch set 1 V +1 06/23/22, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28348

  3. Simon Schaufelberger commented on patch set 1 CR -1 07/05/22, 00:52

    The target branch is wrong. It should be 10.4
  4. Martin Tepper commented on patch set 1 07/05/22, 05:05

    Reply

    Hello Simon, you are right. i have problems to change the target branch. i tried: git push origin HEAD:refs/for/10.4 git commit --amend git push and get "error: src refspec refs/heads/10.4 does not match any" can you give me a hint to solve it? Thanks
  5. Stefan Bürk wrote 07/05/22, 11:15

    Change destination moved from main to 10.4
  6. Simon Schaufelberger uploaded patch set 2 07/05/22, 19:03

  7. Simon Schaufelberger commented on patch set 2 V +1 CR +1 07/05/22, 19:04

    Reply

    Your commands were right but the base was messed up. I fixed it for you now.
    This bug only occurs on TYPO3 10.
  8. core-ci voted on patch set 2 V +1 07/05/22, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28679

  9. Martin Tepper commented on patch set 2 07/06/22, 05:37

    Reply

    Thanks
  10. Stefan Bürk voted on patch set 2 V +2 CR +2 07/07/22, 16:30

  11. Stefan Bürk merged patch set 3 07/07/22, 16:30