Review main Merged

74980[BUGFIX] Remove unneeded padding from search's form-control

Andreas Kienast CR +2 V +2 Easy +1 −5 updated 06/24/22, 11:35

Commit message

The input field used within the backend search form at the top had an
initial padding of 0px which mispositions the search field until all
JavaScript is loaded because the field will be wrapped in a div
container and thus the responsible CSS rule becomes unused.

To solve this wrong positioning, the affected CSS definition is removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Andreas Kienast uploaded patch set 1 06/24/22, 10:48

  2. Andreas Kienast updated the commit message in patch set 2 06/24/22, 10:49

  3. core-ci voted on patch set 2 V +1 06/24/22, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28382

  4. Nikita Hovratov voted on patch set 2 V +1 CR +1 06/24/22, 11:04

  5. core-ci voted on patch set 1 V +1 06/24/22, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28381

  6. Oli Bartsch voted on patch set 2 V +2 CR +2 06/24/22, 11:35

  7. Oli Bartsch merged patch set 3 06/24/22, 11:35