Review main Merged

74990[TASK] Superfluous hook registration in TitleTagRenderingTest

Christian Kuhn CR +2 V +2 Easy +0 −10 updated 06/28/22, 16:58

Commit message

That hook isn't used in this test case since the tests do not
manipulate FE TypoScript. Tests stay green without.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 06/28/22, 15:49

  2. core-ci voted on patch set 1 V +1 06/28/22, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28461

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 06/28/22, 16:52

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 06/28/22, 16:58

  5. Oli Bartsch merged patch set 2 06/28/22, 16:58