Review main Merged

74992[BUGFIX] Use less strict check for empty translated values

Elias Häußler CR +2 V +2 Hard +253 −12 updated 07/02/22, 20:42

Commit message

When translating values in EXT:form, we must ensure to
handle translated values correctly. Prior to this change,
the native PHP function "empty()" was used to determine
if a translated value is valid. This, however, generates
wrong translations for valid empty values, such as "0".
Therefore, the native function has been replaced by a
helper method in TranslationService.

This fix is a potential change of behavior. Translated
values that were previously interpreted as "empty" might
now be rendered as-is. This can possibly lead to a
different rendering result in Frontend forms. Therefore,
this change is not backported to previous versions.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4