Review main Abandoned

75000[BUGFIX] Skip HMAC validation for multi-value properties in form editor

Elias Häußler CR 0 V 0 Easy +1 −1 updated 10/19/22, 06:44

Commit message

With #85044, HMAC validation for form definitions in the backend form
editor was introduced. Since then, a transformed form definition
contains HMAC values for all form elements and their properties, except
for multi-value properties. Those properties were not secured by an
appropriate HMAC value. However, the HMAC validation was still in place,
even for multi-value properties. This led to an exception when trying to
save a form that contains multi-value properties.

Since multi-value properties don't have an appropriate HMAC value, the
HMAC validation is now skipped for those properties.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 1