75007[FEATURE] Include be_group rights from yaml files
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- typo3/sysext/core/Classes/Authentication/GroupResolver.php7+108 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php2+26 −0
- typo3/sysext/core/Configuration/TCA/be_groups.php+12 −1
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-95904-ImportBeGroupsPermissionsFromYamlIncludes.rstnew+119 −0
- typo3/sysext/core/Resources/Private/Language/locallang_tca.xlf+3 −0
- typo3/sysext/core/ext_tables.sql+1 −0
Review log 1722
-
Andreas Häfner uploaded patch set 1 07/01/22, 09:38
-
Andreas Häfner marked it work in progress 07/01/22, 09:39
-
Mathias Brodala commented on patch set 1 07/01/22, 09:43
Thanks A LOT for tackling this. We have been using a tiny subset of this internally for years but never got around finishing/extending it.Feature-95904-ImportBeGroupsAccessRightsFromYamlIncludes.rst:14You mean "permissions" which should be used as term everywhere.Feature-95904-ImportBeGroupsAccessRightsFromYamlIncludes.rst:18"YAML" ;-)Feature-95904-ImportBeGroupsAccessRightsFromYamlIncludes.rst:39This is not necessary and should be removed here.Feature-95904-ImportBeGroupsAccessRightsFromYamlIncludes.rst:76Maybe we can allow a list of values instead of a CSV string here (will need on-the-fly conversion then.) Otherwise we should mention YAML multiline strings to have this in a format suitable for Git: https://yaml-multiline.infoFeature-95904-ImportBeGroupsAccessRightsFromYamlIncludes.rst:80BTW, no need for quotes here. -
core-ci voted on patch set 1 V -1 07/01/22, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28558
-
Andreas Häfner uploaded patch set 2 07/05/22, 06:36
-
core-ci voted on patch set 2 V +1 07/05/22, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28652
-
Andreas Häfner uploaded patch set 3 07/06/22, 06:21
-
Andreas Häfner marked it ready for review 07/06/22, 06:24
-
core-ci voted on patch set 3 V +1 07/06/22, 06:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28691
-
Mathias Brodala commented on patch set 3 07/06/22, 07:16
Feature-95904-ImportBeGroupsAccessRightsFromYamlIncludes.rst:14ReplyDoneFeature-95904-ImportBeGroupsAccessRightsFromYamlIncludes.rst:18ReplyDoneFeature-95904-ImportBeGroupsAccessRightsFromYamlIncludes.rst:39ReplyDoneFeature-95904-ImportBeGroupsAccessRightsFromYamlIncludes.rst:76ReplyDoneFeature-95904-ImportBeGroupsAccessRightsFromYamlIncludes.rst:80ReplyDone -
Simon Schaufelberger commented on patch set 3 CR -1 07/06/22, 08:42
please also have a look at https://github.com/b13/permission-sets which just got open sourced and is doing exactly the same but differently.GroupResolver.php:114no need. can be removed.GroupResolver.php:149annotations can be removedExtensionManagementUtility.php:1204property type missing -
Andreas Häfner uploaded patch set 4 07/14/22, 06:25
-
core-ci voted on patch set 4 V +1 07/14/22, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29113
-
Andreas Häfner commented on patch set 4 07/14/22, 06:40
Reply Unresolved
This Extension applies mapping from special yaml semantic to database based permissions. I wannted to keep configuration simple and compareable to databse so export of existing databasepermissions would be a nobrainer.GroupResolver.php:149ReplyChanged it. But why that? Such return annotations can be found all over the core code. Why should I ommit it at this point? -
Andreas Kienast commented on patch set 4 07/14/22, 06:42
GroupResolver.php:149ReplyThese annotations were required before type declarations were possible. Since this method is declared to return `?string`, the annotation is superfluous. -
Mathias Brodala commented on patch set 4 07/14/22, 09:57
GroupResolver.php:149ReplyAs is the @param annotation which should be dropped too. -
Simon Schaufelberger commented on patch set 4 08/24/23, 15:08
GroupResolver.php:114ReplyDoneGroupResolver.php:149ReplyDoneExtensionManagementUtility.php:1204ReplyDone -
Simon Schaufelberger uploaded patch set 5
V +108/24/23, 15:22 -
core-ci voted on patch set 5 V +1 08/24/23, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45789
-
Jörg Bösche voted on patch set 5 CR +1 08/25/23, 13:43
-
Andreas Häfner voted on patch set 5 V +1 CR +1 08/28/23, 09:30
-
Georg Ringer abandoned the change 06/20/24, 07:30
abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/82189