Review main Merged

75049[BUGFIX] Update @typo3/icons to 3.1.2

Andreas Kienast CR +2 V +2 Easy +7 −7 updated 07/08/22, 10:21

Commit message

The TYPO3 icon set is updated to version 3.1.2 which fixes a regression
with buttons.

See full changelog here:
https://github.com/TYPO3/TYPO3.Icons/compare/v3.1.0...v3.1.2

Executed commands:

    cd Build
    nvm use
    yarn add @typo3/icons@^3.1.2
    grunt build

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1317

  1. Andreas Kienast uploaded patch set 1 07/08/22, 07:22

  2. Andreas Kienast updated the commit message in patch set 2 07/08/22, 07:23

  3. Nikita Hovratov voted on patch set 2 V +1 CR +1 07/08/22, 07:29

  4. core-ci voted on patch set 1 V +1 07/08/22, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28741

  5. core-ci voted on patch set 2 V +1 07/08/22, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28742

  6. Andreas Kienast updated the commit message in patch set 3 07/08/22, 09:09

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 07/08/22, 09:10

  8. core-ci voted on patch set 3 V +1 07/08/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28748

  9. Nikita Hovratov voted on patch set 3 V +1 CR +1 07/08/22, 09:33

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 07/08/22, 09:55

  11. Andreas Kienast commented on patch set 3 V 0 CR -1 07/08/22, 09:56

    Benji found another issue
  12. Andreas Kienast uploaded patch set 4 07/08/22, 10:02

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 07/08/22, 10:07

  14. core-ci voted on patch set 4 V +1 07/08/22, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28750

  15. Nikita Hovratov voted on patch set 4 V +1 CR +1 07/08/22, 10:15

  16. Andreas Kienast voted on patch set 4 V +2 CR +2 07/08/22, 10:21

  17. Andreas Kienast merged patch set 5 07/08/22, 10:21