Review main Merged

75072[TASK] Move escapeLikeWildcards to Connection

Oliver Hader CR +2 V +2 Easy +13 −1 updated 07/08/22, 13:14

Commit message

Escaping SQL `LIKE` wildcards is only provided via
`QueryBuilder::escapeLikeWildcards()`, but would be useful as
`Connection::escapeLikeWildcards()` as well (without having the
demand to create another `QueryBuilder` instance).

With this patch, both methods are available:
* `QueryBuilder::escapeLikeWildcards()`, and
* `Connection::escapeLikeWildcards()`

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Oliver Hader uploaded patch set 1 07/08/22, 11:54

  2. Oliver Klee commented on patch set 1 07/08/22, 11:58

    I propose we cover both methods with tests.
  3. core-ci voted on patch set 1 V +1 07/08/22, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28754

  4. Simon Schaufelberger voted on patch set 1 V +1 CR +1 07/08/22, 12:27

  5. Stefan Bürk commented on patch set 1 V +1 CR +1 07/08/22, 12:27

    Reply

    Generally ack. But if it is fine for you, I would leave it out for this "move" patch and do it in a follow up / dedicated patch. I have it on my todo list to extend testing in that area for methods core added into the fascade classes and tests are missing for a later point. Stumpled upon that as I'm working on a PoC which addes some methods too (and needs tests for it). So I would add/increase test covereage along for existing/untested methods along with the tests for the new methods. Would this be okay for you ?
  6. Oliver Klee commented on patch set 1 CR +1 07/08/22, 12:38

    Reply

    Ack
  7. Andreas Kienast voted on patch set 1 V +2 CR +2 07/08/22, 13:14

  8. Andreas Kienast merged patch set 2 07/08/22, 13:14