Review main Merged

75091[BUGFIX] Cast `$chars` argument of `fixed_lgd_cs()` to int

Andreas Kienast CR +2 V +2 Normal +29 −27 updated 08/10/22, 07:51

Commit message

Since #97578, `GeneralUtility` is declared strict, potentially breaking
calls to `fixed_lgd_cs()` in at least the "List" module. The argument
`$chars` must be of type int, but sometimes it's a string which breaks
the call of `abs()`.

All calls to this method are adjusted, where required, and the value is
explicitly cast to int.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 18