Review main Merged

75098[BUGFIX] Replace usage of btn-block

Oli Bartsch CR +2 V +2 Normal +33 −30 updated 01/14/25, 14:29

Commit message

Usage of button specific classes was mostly removed
in bootstrap 5. However, core still supports some of
those classes, e.g. "btn-block".

Using those classes however often leads to misbehavior
updating other components, which rely on newer layout
technologies.

To circumvent this, usage of the "btn-block" class is
migrated at all places, while the class definition is still
kept for backwards compatibility.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 11

Review log 810

  1. Oli Bartsch uploaded patch set 1 07/11/22, 13:35

  2. Oli Bartsch uploaded patch set 2 07/11/22, 13:40

  3. core-ci voted on patch set 2 V +1 07/11/22, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28890

  4. core-ci voted on patch set 1 V -1 07/11/22, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28888

  5. Andreas Kienast voted on patch set 2 CR +1 07/11/22, 14:16

  6. Andreas Kienast voted on patch set 2 V +1 07/11/22, 14:19

  7. Jochen Roth voted on patch set 2 V +1 CR +1 07/11/22, 14:31

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 07/11/22, 14:33

  9. Oli Bartsch merged patch set 3 07/11/22, 14:33

  10. Benjamin Kott commented on patch set 3 01/14/25, 14:29

    this was linked in a different patch. the assumption taken here is wrong that btn-block needed to be replaced. and we will reintroduce it where it needs to be. d-grid, d-flex, whatever is a nogo and should only be used as long as we cannot clearly implement a component. this note is added here as reference for the next one, finding this patch. no direct action needed.