75098[BUGFIX] Replace usage of btn-block
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 3
Files 11
- Build/Sources/Sass/component/_buttons.scss+2 −1
- Build/Sources/TypeScript/backend/localization.ts+3 −3
- typo3/sysext/backend/Resources/Private/Layouts/Login.html+11 −9
- typo3/sysext/backend/Resources/Private/Templates/Login/ForgetPasswordForm.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/Login/ResetPasswordForm.html+5 −5
- typo3/sysext/backend/Resources/Private/Templates/Mfa/Auth.html+2 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/localization.js+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertElements.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertPages.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Partials/InfoModifyTable.html+4 −4
Review log 810
-
Oli Bartsch uploaded patch set 1 07/11/22, 13:35
-
Oli Bartsch uploaded patch set 2 07/11/22, 13:40
-
core-ci voted on patch set 2 V +1 07/11/22, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28890
-
core-ci voted on patch set 1 V -1 07/11/22, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28888
-
Andreas Kienast voted on patch set 2 CR +1 07/11/22, 14:16
-
Andreas Kienast voted on patch set 2 V +1 07/11/22, 14:19
-
Jochen Roth voted on patch set 2 V +1 CR +1 07/11/22, 14:31
-
Oli Bartsch voted on patch set 2 V +2 CR +2 07/11/22, 14:33
-
Oli Bartsch merged patch set 3 07/11/22, 14:33
-
Benjamin Kott commented on patch set 3 01/14/25, 14:29
this was linked in a different patch. the assumption taken here is wrong that btn-block needed to be replaced. and we will reintroduce it where it needs to be. d-grid, d-flex, whatever is a nogo and should only be used as long as we cannot clearly implement a component. this note is added here as reference for the next one, finding this patch. no direct action needed.