Review main Abandoned

75108[FEATURE] Make linkable page types configurable

Frank Nägler CR 0 V -1 Normal +96 −48 updated 02/07/26, 11:52

Commit message

To be able to explicitly define which page type can be linked in the
frontend, the page type setting `isLinkable` is introduced to be used
in `$GLOBALS['PAGES_TYPES']`.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 9

Review log 1724

  1. Frank Nägler uploaded patch set 1 07/11/22, 16:34

  2. core-ci voted on patch set 1 V -1 07/11/22, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28909

  3. Frank Nägler uploaded patch set 2 07/11/22, 16:49

  4. core-ci voted on patch set 2 V +1 07/11/22, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28912

  5. Frank Nägler uploaded patch set 3 07/12/22, 09:06

  6. core-ci voted on patch set 3 V +1 07/12/22, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28953

  7. Andreas Kienast commented on patch set 3 CR -1 07/12/22, 09:58

    on it
  8. Andreas Kienast uploaded patch set 4 07/12/22, 10:03

  9. Andreas Kienast voted on patch set 4 V +1 CR +1 07/12/22, 10:04

  10. core-ci voted on patch set 4 V +1 07/12/22, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28959

  11. Benni Mack commented on patch set 4 07/12/22, 12:01

    PageRepository.php:521

    wrong place here unforatunately.
  12. Frank Nägler commented on patch set 4 V -1 07/14/22, 18:06

    -1 until another pre-patch by Benni is merged.
  13. Benni Mack commented on patch set 4 11/03/22, 17:00

    Pre-Patch is merged, I think we can now continue :)
  14. Andreas Kienast commented on patch set 4 02/10/23, 09:27

    ping
  15. Frank Nägler uploaded patch set 5 CR +1 V +1 02/23/23, 12:50

  16. Frank Nägler commented on patch set 5 02/23/23, 12:51

    PageRepository.php:521 Reply

    Ack
  17. core-ci voted on patch set 5 V +1 02/23/23, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38016

  18. Benni Mack commented on patch set 6 V +1 02/23/23, 14:20

    Published edit on patch set 5.
  19. core-ci voted on patch set 6 V +1 02/23/23, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38022

  20. Benni Mack commented on patch set 6 03/15/23, 11:38

    I think we have more candidates to replace: PageProvider->isExcludedDoktype, also RecordProvider, Recordlistcontroller, PageLayoutController, EditDocumentController. I guess, my main question is "is linkable" the same as "is previewable"?
  21. Frank Nägler commented on patch set 6 CR -1 04/28/23, 10:51

    work on it

    Reply

    I am okay to extend the system and add a new flag isPreviewable, maybe some more flags. I will check the usage and extend the patch.
  22. Frank Nägler uploaded patch set 7 CR -1 V +1 04/28/23, 11:35

  23. core-ci voted on patch set 7 V -1 04/28/23, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41291

  24. Benni Mack abandoned the change 02/07/26, 11:52

    not needed anymore, already merged