75127[BUGFIX] Add cursor on toggle checkboxes
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
Review log 3748
Show 1623 earlier messages
-
Tomas Norre Mikkelsen uploaded patch set 1 07/12/22, 12:58
-
Oliver Klee commented on patch set 1 07/12/22, 12:59
We probably need to rebuild the CSS assets.Probably 10.5 -> 11.5 -
Tomas Norre Mikkelsen updated the commit message in patch set 2 07/12/22, 12:59
-
Tomas Norre Mikkelsen commented on patch set 2 07/12/22, 13:01
Reply
We do, but wasn't sure if they should be committed to. Will do.Reply
Done -
Tomas Norre Mikkelsen uploaded patch set 3 07/12/22, 13:02
-
core-ci voted on patch set 1 V -1 07/12/22, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28972
-
core-ci voted on patch set 2 V -1 07/12/22, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28973
-
core-ci voted on patch set 3 V +1 07/12/22, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28975
-
Tomas Norre Mikkelsen uploaded patch set 4 07/12/22, 13:24
-
core-ci voted on patch set 4 V +1 07/12/22, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28977
-
Andreas Kienast commented on patch set 4 07/12/22, 14:02
I wonder if it wouldn't make sense to put a cursor on all checkboxes and radios to have a consistent behavior. -
Tomas Norre Mikkelsen commented on patch set 4 07/12/22, 14:16
Reply
As I see it, this should add it to all checkboxes, but you're right about the radio-button, these are not included here. -
Björn Jacob commented on patch set 4 V +1 CR +1 07/12/22, 15:06
Works fine, especially in form editor. -
Tomas Norre Mikkelsen uploaded patch set 5 07/14/22, 12:02
-
core-ci voted on patch set 5 V +1 07/14/22, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29142
-
Oliver Klee wrote 07/14/22, 12:28
Removed cc Oliver Klee. -
Björn Jacob voted on patch set 5 V +1 CR +1 07/14/22, 13:02
-
Anja Leichsenring uploaded patch set 6 07/18/22, 13:24
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 07/18/22, 13:24
-
core-ci voted on patch set 6 V +1 07/18/22, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29333
-
Anja Leichsenring uploaded patch set 7 08/02/22, 08:24
-
Anja Leichsenring voted on patch set 7 V +1 CR +1 08/02/22, 08:26
-
core-ci voted on patch set 7 V +1 08/02/22, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29774
-
Simon Schaufelberger uploaded patch set 8 08/03/22, 16:37
-
Simon Schaufelberger voted on patch set 8 V +1 CR +1 08/03/22, 16:44
-
core-ci voted on patch set 8 V +1 08/03/22, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29800
-
Riccardo De Contardi commented on patch set 8 V +1 08/04/22, 07:51
Tested with latest master -
Matthäus Gundlach voted on patch set 8 CR +1 08/05/22, 20:00
-
Matthäus Gundlach voted on patch set 8 V +1 08/05/22, 20:21
-
Marc Hirdes voted on patch set 8 V +1 CR +1 08/05/22, 20:22
-
Thomas Anders commented on patch set 8 CR -1 08/05/22, 21:01
After applying the patch, normal checkboxes have a hover-pointer a few pixels left from the checkbox. Its because the .form-check-input is moved out of the way and the checkbox itself uses the label. -
Simon Schaufelberger commented on patch set 8 08/05/22, 21:04
Reply
Can you provide a screenshot in forge please? -
Matthäus Gundlach voted on patch set 8 V 0 08/05/22, 21:11
-
Matthäus Gundlach uploaded patch set 9 08/05/22, 23:13
-
Simon Schaufelberger commented on patch set 9 CR -1 08/05/22, 23:19
_main_form.scss:335since you also change radio buttons, you also need to adjust the commit message. -
core-ci voted on patch set 9 V +1 08/05/22, 23:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29878
-
Matthäus Gundlach updated the commit message in patch set 10 08/06/22, 16:26
-
core-ci voted on patch set 10 V +1 08/06/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29907
-
Matthäus Gundlach voted on patch set 10 V +1 CR +1 08/06/22, 21:15
-
Matthäus Gundlach voted on patch set 10 V 0 CR 0 08/06/22, 21:18
-
Thomas Anders commented on patch set 10 V +1 CR +1 08/07/22, 08:40
Reply
Sure - added itWorks for me. Tested on latest main -
Nikita Hovratov uploaded patch set 11 08/07/22, 14:05
-
Nikita Hovratov commented on patch set 11 08/07/22, 14:08
Reply
DoneReply
Done_main_form.scss:335ReplyDone -
core-ci voted on patch set 11 V +1 08/07/22, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29918
-
Nikita Hovratov voted on patch set 11 V +1 CR +1 08/07/22, 14:20
-
Christian Kuhn voted on patch set 11 V +1 CR +1 08/07/22, 14:21
-
Nikita Hovratov voted on patch set 11 V +2 CR +2 08/07/22, 14:22
-
Nikita Hovratov merged patch set 12 08/07/22, 14:22