Review main Merged

75130[BUGFIX] Remove additional button classes from dropdown items

Oli Bartsch CR +2 V +2 Normal +41 −28 updated 07/12/22, 16:56

Commit message

When using a <button> in a bootsrap dropdown
menu, additional button classes, such as ".btn"
are not necessary, but might lead to display errors.

Those classes are therefore now removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jochen Roth +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1114

  1. Oli Bartsch uploaded patch set 1 07/12/22, 14:33

  2. core-ci voted on patch set 1 V -1 07/12/22, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28986

  3. Oli Bartsch uploaded patch set 2 07/12/22, 14:49

  4. core-ci voted on patch set 2 V +1 07/12/22, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28987

  5. Oliver Hader voted on patch set 2 CR +1 07/12/22, 15:10

  6. Andreas Kienast commented on patch set 2 V -1 07/12/22, 15:20

    It seems the "disabled" state is not rendered correctly anymore, e.g. in the checkbox dropdown in the file list.
  7. Oli Bartsch uploaded patch set 3 07/12/22, 15:34

  8. Oli Bartsch commented on patch set 3 07/12/22, 15:35

    Reply

    Extended the corresponding bootstrap styling for the previously used "opacity" and "box-shadow".
  9. core-ci voted on patch set 3 V +1 07/12/22, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28991

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 07/12/22, 16:07

  11. Jochen Roth voted on patch set 3 V +1 CR +1 07/12/22, 16:44

  12. Nikita Hovratov voted on patch set 3 V +1 CR +1 07/12/22, 16:56

  13. Andreas Kienast voted on patch set 3 V +2 CR +2 07/12/22, 16:56

  14. Andreas Kienast merged patch set 4 07/12/22, 16:56