Review main Merged

75166[BUGFIX] Prevent DataHandler warning for non-workspace tables

Nicole Hummel CR +2 V +2 Easy +1 −1 updated 07/14/22, 07:52

Commit message

If a record with associated inline records gets copied, the DataHandler
always handles the record creation as new versions. This raises some
warning when the corresponding table doesn't support workspaces. This
patch prevents warnings when a corresponding irre-table cannot create
any new version of a record.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1214

  1. Nicole Hummel uploaded patch set 1 07/13/22, 12:52

  2. Christian Kuhn commented on patch set 1 CR +1 07/13/22, 12:58

    sounds and reads legit. will give it a testing-shot soon.
  3. core-ci voted on patch set 1 V +1 07/13/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29062

  4. Christian Kuhn voted on patch set 1 V +1 07/13/22, 15:11

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 07/13/22, 15:37

  6. Nikita Hovratov commented on patch set 1 07/13/22, 16:15

    DataHandler.php:3856

    Just a nitpick: We could use BU::isTableWorkspaceEnabled here instead.
  7. Christian Kuhn commented on patch set 1 07/14/22, 07:20

    DataHandler.php:3856 Reply

    thx. adapted.
  8. Christian Kuhn uploaded patch set 2 07/14/22, 07:21

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 07/14/22, 07:21

  10. Anja Leichsenring voted on patch set 2 V +1 CR +1 07/14/22, 07:23

  11. core-ci voted on patch set 2 V +1 07/14/22, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29119

  12. Nikita Hovratov voted on patch set 2 V +1 CR +1 07/14/22, 07:36

  13. Christian Kuhn voted on patch set 2 V +2 CR +2 07/14/22, 07:52

  14. Christian Kuhn merged patch set 3 07/14/22, 07:52