Review main Merged

75168[TASK] Avoid setUpBackendUserFromFixture() in functionals

Christian Kuhn CR +2 V +2 Expert +414 −995 updated 07/13/22, 19:58

Commit message

The testing-framework method setUpBackendUserFromFixture()
is kinda flawed since it does two things at once: It
creates db records and creates global state. This is
unfortunate in various cases, especially when  db
snapshoting is used. Additionally, it relies on a
class property which defaults to a fixture file
delivered by testing-framework in XML format. We
want to get rid of the .xml fixtures, and we don't
want that the testing-framework delivers default
fixtures.

The patch adapts all usages of the property and
of method setUpBackendUserFromFixture() by splitting
it into two calls to first insert a local extension
fixture .csv file and to then call the backend user
init helper method.

This finishes the removal of .xml fixture uses
in the core.

$ composer req --dev typo3/testing-framework:dev-main

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 111

Show 91 more files