Review main Merged

75173[TASK] Speed up a functional test using snapshot

Christian Kuhn CR +2 V +2 Easy +8 −13 updated 07/14/22, 07:18

Commit message

Using functional test related .yaml scenario setup
which uses DataHandler to prime the test database
is pretty slow.
TreeControllerTest can speed up using the
withDatabaseSnapshot() method to cache db results
for subsequent tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 07/14/22, 06:37

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 07/14/22, 06:40

  3. core-ci voted on patch set 1 V +1 07/14/22, 06:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29117

  4. Christian Kuhn commented on patch set 1 V +2 CR +2 07/14/22, 07:18

    merging as close-to-nobrainer in test-only.
  5. Christian Kuhn merged patch set 2 07/14/22, 07:18