Review main Merged

75174[TASK] Streamline functional test snapshots

Christian Kuhn CR +2 V +2 Normal +76 −110 updated 07/14/22, 09:15

Commit message

The testing-framework functional test db snapshot
helper expects the database to be empty when
withDatabaseSnapshot() is called. Rows should
only be populated within the create callback.

There was a workaround in testing-framework to
relax this restriction due to unfortunate backend
user related setup code flow. This has been resolved
with #97928, so the testing-framework snapshot can
be more strict on this now.

The patch adapts a couple of snapshot usages to
align to this enforced restriction.

$ composer req --dev typo3/testing-framework:dev-main

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 8