75181[WIP][TASK] Avoid usages of TemplateService->rootline
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 6
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+22 −21
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+9 −11
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+5 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+22 −37
Review log 69
-
Christian Kuhn uploaded patch set 1 07/14/22, 16:49
-
core-ci voted on patch set 1 V -1 07/14/22, 16:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29159
-
Christian Kuhn uploaded patch set 2 07/15/22, 10:40
-
core-ci voted on patch set 2 V -1 07/15/22, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29202
-
Christian Kuhn uploaded patch set 3 07/15/22, 12:02
-
Christian Kuhn commented on patch set 3 V -1 07/15/22, 12:03
this needs more work. -
core-ci voted on patch set 3 V -1 07/15/22, 12:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29208
-
Christian Kuhn commented on patch set 3 07/16/22, 11:02
i'll abandon this approach and start a-new. -
Christian Kuhn abandoned the change 07/16/22, 11:02