Review main Abandoned

75186[TASK] Show environment check messages in reports module

Georg Ringer CR 0 V 0 Easy +12 −9 updated 06/11/24, 16:00

Commit message

Instead of just showing the number of failing tests, the actual
messages should be shown.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 07/14/22, 19:43

  2. Georg Ringer commented on patch set 1 07/14/22, 19:43

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 07/14/22, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29171

  4. Andreas Kienast commented on patch set 1 CR -1 07/15/22, 11:12

    EnvironmentStatusReport.php:118

    $statusObject->getSeverity() !== ContextualFeedbackSeverity::OK
  5. Georg Ringer uploaded patch set 2 07/15/22, 15:26

  6. core-ci voted on patch set 2 V +1 07/15/22, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29231

  7. Josef Glatz commented on patch set 2 07/26/22, 07:24

    Feedback already implemented by Georg.

    EnvironmentStatusReport.php:118 Reply

    Done
  8. Christian Kuhn commented on patch set 2 07/27/22, 12:57

    Unsure here, at least as proposed: I guess there was a reason to not implement this earlier: Some of these information are security relevant, like "Trusted hosts pattern is insecure". Even though the reports module is admin-only, the details from ext:install environment status are system-maintainer-only. I guess that was the reason to only show the counts at this point. I'd say that if we want that output within ext:reports, we should check if the admin user is a system maintainer.
  9. Christian Kuhn commented on patch set 2 CR -1 07/27/22, 12:59

    Unresolved

    adding -1 for now due to security relevant information disclosure considerations. what do you think?
  10. Markus Klein commented on patch set 2 09/28/22, 14:15

    Reply

    I'm not sure if the distinction is of any importance at this stage. Admins already have a lot of permissions and see system-relevant infos in stacktraces and so on.
  11. Georg Ringer abandoned the change 06/11/24, 16:00

    abandoned cause of lack of consensus