Review main Abandoned Breaking

75187[WIP][!!!][BUGFIX] Use "floating" and "free" language concepts in extbase properly

Georg Ringer CR 0 V 0 Easy +5 −0 updated 12/05/23, 08:56

Commit message

Within TYPO3's LanguageAspect there are four options for doing
overlays:
OVERLAYS_OFF -> fetch records in a specific language directly
OVERLAYS_MIXED -> fetch default records + do overlays if available
OVERLAYS_ON -> fetch default records + do overlays - discard if no overlay is available
OVERLAYS_ON_WITH_FLOATING -> same as OVERLAYS_ON PLUS the records that have no l10n_parent.

This patch fixes the OVERLAYS_ON_WITH_FLOATING + OVERLAYS_OFF
functionality when querying Extbase records + relations.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 69

  1. Georg Ringer uploaded patch set 1 07/14/22, 20:30

  2. core-ci voted on patch set 1 V -1 07/14/22, 20:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29174

  3. Georg Ringer uploaded patch set 2 07/14/22, 20:48

  4. core-ci voted on patch set 2 V -1 07/14/22, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29175

  5. Benni Mack commented on patch set 2 07/15/22, 09:02

    This change is ready for review.
  6. Benni Mack updated the commit message in patch set 3 07/15/22, 09:05

  7. core-ci voted on patch set 3 V -1 07/15/22, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29191

  8. Oliver Klee commented on patch set 3 07/16/22, 12:19

    We should cover this with tests.
  9. Benni Mack abandoned the change 12/05/23, 08:56