75190[TASK] Have ResourceCompressor deliver consistent results
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 69
-
Benni Mack uploaded patch set 1 07/15/22, 11:55
-
core-ci voted on patch set 1 V -1 07/15/22, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29206
-
Benni Mack uploaded patch set 2 07/15/22, 12:58
-
core-ci voted on patch set 2 V +1 07/15/22, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29211
-
Markus Klein commented on patch set 2 07/15/22, 17:11
Test-cases that come to my mind with compression enabled for FE and BE: * composer installation * composer installation with composer-installers v4 * non-composer in docroot * non-composer in docroot/subfolder The latter was a major regression candidate in the past, as far as I rememberResourceCompressor.php:46hm... "will be removed once this class is removed" guess this is obvious. ;-) this property goes with the classResourceCompressor.php:427lets add `string`ResourceCompressor.php:433that should be part of the phpdoc -
Benni Mack uploaded patch set 3 07/28/22, 12:20
-
Benni Mack commented on patch set 3 07/28/22, 12:21
ResourceCompressor.php:46ReplyDoneResourceCompressor.php:427ReplyDoneResourceCompressor.php:433ReplyDone -
core-ci voted on patch set 3 V +1 07/28/22, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29643
-
Benni Mack abandoned the change 10/11/22, 08:47
not needed anymore