Review main Abandoned

75190[TASK] Have ResourceCompressor deliver consistent results

Benni Mack CR 0 V 0 Normal +40 −147 updated 10/11/22, 08:47

Commit message

With this change, ResourceCompressor always returns proper
absolute paths.

This is especially crucial as TYPO3 Backend does not have
absRefPrefix, and still juggles around the concept of
referencing files with "../typo3conf".

This change tries to simplify all of the path resolving,
making fewer use-cases of getRelativePathTo() and resolveBackPath().

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 69

  1. Benni Mack uploaded patch set 1 07/15/22, 11:55

  2. core-ci voted on patch set 1 V -1 07/15/22, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29206

  3. Benni Mack uploaded patch set 2 07/15/22, 12:58

  4. core-ci voted on patch set 2 V +1 07/15/22, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29211

  5. Markus Klein commented on patch set 2 07/15/22, 17:11

    Test-cases that come to my mind with compression enabled for FE and BE: * composer installation * composer installation with composer-installers v4 * non-composer in docroot * non-composer in docroot/subfolder The latter was a major regression candidate in the past, as far as I remember

    ResourceCompressor.php:46

    hm... "will be removed once this class is removed" guess this is obvious. ;-) this property goes with the class

    ResourceCompressor.php:427

    lets add `string`

    ResourceCompressor.php:433

    that should be part of the phpdoc
  6. Benni Mack uploaded patch set 3 07/28/22, 12:20

  7. Benni Mack commented on patch set 3 07/28/22, 12:21

    ResourceCompressor.php:46 Reply

    Done

    ResourceCompressor.php:427 Reply

    Done

    ResourceCompressor.php:433 Reply

    Done
  8. core-ci voted on patch set 3 V +1 07/28/22, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29643

  9. Benni Mack abandoned the change 10/11/22, 08:47

    not needed anymore