Review main Merged

75197[BUGFIX] Use correct fallback types in ImageDimension

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 07/15/22, 20:59

Commit message

Replace wrong null fallback for "width" and "height"
with empty string and also cast the values before
passing to GraphicalFunctions->getImageScale()
which expects them to be string.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 07/15/22, 20:22

  2. core-ci voted on patch set 1 V +1 07/15/22, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29242

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 07/15/22, 20:30

  4. Oli Bartsch merged patch set 2 07/15/22, 20:30

  5. Oli Bartsch wrote 07/15/22, 20:54

    Created a revert of this change as Ice9ccc3cf27758673358f1b6501c3f71130e732d
  6. Oli Bartsch commented on patch set 2 07/15/22, 20:59

    Sorry, I mixed this up with a backport. Revert at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75197