Review main Merged

75199[BUGFIX] Use correct fallback types in ImageDimension

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 07/16/22, 11:05

Commit message

Replace wrong null fallback for "width" and "height"
with empty string and also cast the values before
passing to GraphicalFunctions->getImageScale()
which expects them to be string.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 07/15/22, 21:07

  2. Jochen Roth voted on patch set 1 V +1 CR +1 07/15/22, 21:10

  3. core-ci voted on patch set 1 V +1 07/15/22, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29245

  4. Oliver Klee voted on patch set 1 CR +1 07/16/22, 06:28

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 07/16/22, 11:04

  6. Christian Kuhn merged patch set 2 07/16/22, 11:05