75200[BUGFIX] Streamline URL softref parsing with a modern approach
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 2339
Show 814 earlier messages
-
Nikita Hovratov uploaded patch set 1 07/15/22, 22:11
-
core-ci voted on patch set 1 V -1 07/15/22, 22:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29246
-
Nikita Hovratov uploaded patch set 2 07/15/22, 22:21
-
core-ci voted on patch set 2 V +1 07/15/22, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29247
-
Nikita Hovratov uploaded patch set 3 07/15/22, 22:50
-
Nikita Hovratov uploaded patch set 4 07/15/22, 22:52
-
core-ci voted on patch set 4 V +1 07/15/22, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29249
-
Stefan Bürk uploaded patch set 5 07/31/22, 00:58
-
core-ci voted on patch set 5 V +1 07/31/22, 01:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29732
-
Stefan Bürk uploaded patch set 6 07/31/22, 01:09
-
core-ci voted on patch set 6 V +1 07/31/22, 01:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29734
-
Nikita Hovratov uploaded patch set 7 07/31/22, 20:27
-
core-ci voted on patch set 7 V -1 07/31/22, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29761
-
Nikita Hovratov uploaded patch set 8 07/31/22, 20:35
-
core-ci voted on patch set 8 V +1 07/31/22, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29762
-
Stefan Bürk uploaded patch set 9 08/12/22, 20:03
-
core-ci voted on patch set 9 V +1 08/12/22, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30123
-
Sybille Peters commented on patch set 9 V +1 08/13/22, 05:15
Is working nicely and also fixes https://forge.typo3.org/issues/98120UrlSoftReferenceParserTest.php:121The set in the data provider is a little inconsistent. In the Test class there is already either an (array of) array elements with 2 elements (unnamed), with 2 elements (named: content, elements) OR an element and an array with these 2 elements. Now we add another variant which is 3 elements (without the last 2 'content' and 'elements' being in an array). For me, that makes the tests more difficult to understand because I look at the test function and it's yes, it expects 2 arguments, why are we giving 3? Unifying the test is probably off scope, but maybe the new data provider entries could at least stick to one of the conventions? (we could also add the datatype of the array elements later in a phpdoc and enforce this with phpstan) -
Stefan Bürk commented on patch set 9 08/13/22, 12:03
UrlSoftReferenceParserTest.php:121ReplyHave seen this to - and you are right. The "array key" naming is "optional". This should be cleaned/streamlined in a dedicated patch directly after this patch. -
Benni Mack updated the commit message in patch set 10
V +105/03/23, 09:22 -
core-ci voted on patch set 10 V -1 05/03/23, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41400
-
Oliver Hader rebased onto patch set 11
V -105/03/23, 12:39 -
core-ci voted on patch set 11 V +1 05/03/23, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41527
-
Stefan Bürk rebased onto patch set 12
V +107/20/23, 00:00 -
core-ci voted on patch set 12 V +1 07/20/23, 00:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44322
-
Nikita Hovratov rebased onto patch set 13
V +107/29/23, 21:22 -
Nikita Hovratov commented on patch set 13 07/29/23, 21:23
UrlSoftReferenceParserTest.php:121ReplyAck -
core-ci voted on patch set 13 V +1 07/29/23, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44741
-
Oliver Klee voted on patch set 13 V +1 07/30/23, 10:30
-
Nikita Hovratov uploaded patch set 14
V +111/22/23, 22:11 -
core-ci voted on patch set 14 V -1 11/22/23, 22:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49567
-
Nikita Hovratov uploaded patch set 15
V -111/22/23, 22:19 -
core-ci voted on patch set 15 V +1 11/22/23, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49568
-
Nikita Hovratov rebased onto patch set 16
V +101/06/24, 22:35 -
core-ci voted on patch set 16 V +1 01/06/24, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51176
-
Nikita Hovratov rebased onto patch set 17
V +101/24/24, 23:41 -
core-ci voted on patch set 17 V +1 01/24/24, 23:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52120
-
Oliver Hader updated the commit message in patch set 18
V +110/18/24, 14:07 -
Nikita Hovratov abandoned the change 12/05/24, 19:31
2,5 years no reviews