Review main Merged

75202[TASK] Show languageIds in site module overview

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 07/27/22, 14:47

Commit message

It is convenient to see the languageId directly in the
overview, without having to click on the edit button. This
is especially useful for sites with a huge amount of
languages.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Nikita Hovratov uploaded patch set 1 07/16/22, 01:22

  2. core-ci voted on patch set 1 V +1 07/16/22, 01:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29253

  3. Benni Mack voted on patch set 1 V +1 CR +1 07/16/22, 08:12

  4. Oliver Klee voted on patch set 1 CR +1 07/16/22, 08:25

  5. Oli Bartsch commented on patch set 1 07/16/22, 09:07

    To be consistent, shouldn't this be [ID: XY], as done for the display of the rootPageId next to the sites' name in the first column?
  6. Oli Bartsch commented on patch set 1 07/16/22, 09:08

    Reply

    .
  7. Nikita Hovratov commented on patch set 1 07/16/22, 12:22

    Reply

    In the list view of all languages the id is also displayed like this. And looking at TYPO3 as a whole, I can only find the [id: xy] syntax for your mentioned rootPageId and in the ElementInformation view. So, if it's not a blocker for you, I would keep the short version (I think it's clear to everyone).
  8. Andreas Kienast voted on patch set 1 V +1 CR +1 07/16/22, 13:27

  9. Andreas Kienast commented on patch set 1 07/16/22, 13:28

    Not merging right now to wait for response from Oli.
  10. Oli Bartsch commented on patch set 1 V +2 CR +2 07/27/22, 14:47

    Reply

    Ack
  11. Oli Bartsch merged patch set 2 07/27/22, 14:47