Review main Merged

75205[TASK] Avoid misusing element browser for link handler concerns

Christian Kuhn CR +2 V +2 Hard +148 −141 updated 07/16/22, 13:31

Commit message

This resolves a mixup in ext:recordlist:

The "Browser" classes are the "element browser" modals, used
when adding FAL images to records and when adding relations
for type="group".

The "LinkHandler" classes are a distinct construct used to
create the "t3://" syntax when linking record fields and
RTE text to a page, telephone, external URL and so on. They
are rendered as single tabs in the link handler modal.

Class LinkHandler/RecordLinkHandler allows linking to arbitrary
records. Typical example is linking to single ext:news records,
which can be configured using PageTsConfig TCEMAIN.linkHandler.

Class LinkHandler/RecordLinkHandler misuses the element browser
abstraction to list records. This materializes in class
Browser/RecordBrowser, which is not used as element browser as
such, but is just a client class of LinkHandler/RecordLinkHandler.
The two class namespaces however shouldn't interfere with
each other.

The patch resolves this by moving the code from
Browser/RecordBrowser into LinkHandler/RecordLinkHandler and
streamlining it to what is really needed. A series of changed
and added comments should improve the overall constructs
along the way.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 4

Files 15