Review 11.5 Merged

75228[TASK] Avoid deprecated `utf_decode()` method in tests

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 07/27/22, 13:49

Commit message

With PHP 8.2 old and unreliable methods `utf8_encode()`
and `utf8_decode()` have been deprecated and will be
removed in PHP 9.0.

There are several ways to replace these methods, although
none of them are "ensured" to be native enabled in PHP.

We need to replace these methods in tests only, and as
we have testing setup fully under control, this patch
use `mb_convert_encoding()` from php extension `mbstring`
to avoid deprecated methods and corresponding native php
deprecation messages in functional test.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Stefan Bürk commented on patch set 1 07/27/22, 13:41

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 CR +1 07/27/22, 13:48

  3. core-ci voted on patch set 1 V +1 07/27/22, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29615

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 07/27/22, 13:49

  5. Stefan Bürk merged patch set 2 07/27/22, 13:49