Review main Merged

75232[TASK] Avoid using TemplateService->rootLine

Christian Kuhn CR +2 V +2 Normal +143 −65 updated 07/18/22, 20:14

Commit message

With the new TypoScript parser, we should start
phasing out TemplateService (tsfe->tmpl in FE).

One of it's usages in Frontend is tmpl->rootLine.
This property looks as if it's identical to
tsfe->rootLine, but it isn't, since it's in a
different order and stops at sys_template records
with root flag.

However, tmpl->rootLine is also assigned in Frontend
as tsfe->config['rootLine']. The patch changes all
usages of tmpl->rootLine to this and sanitizes access
along the way. Additional comments now document the
subtle differences.

We do not add a deprecation at this point, since
the entire class will be fully deprecated later.

Note the new TypoScript parser construct can not
expose this "local" or "partial" rootLine yet. The
TypoScript/IncludeTree/TreeBuilder class will be
refactored a bit with an additional patch when the
new parser is being used in the Frontend.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 10