Review main Abandoned

75235[WIP][FEATURE] Ajax loading for delete confirmation modal

Jochen Roth CR 0 V -1 Impossible +10628 −387 updated 07/15/26, 10:27

Commit message

Currently all information for the delete modal
is store as data attributes. This adds unnecessary
query to each page load in the backend.

To circumvent the useless queries a modal
controller was added to provide the
required information.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Files 62

Show 42 more files

Review log 2127

Show 2 earlier messages
  1. Jochen Roth uploaded patch set 1 07/17/22, 22:48

  2. Jochen Roth wrote 07/17/22, 22:48

    Set private
  1. Jochen Roth marked it work in progress 07/17/22, 22:49

  2. Jochen Roth uploaded patch set 2 07/25/22, 21:43

  3. Jochen Roth uploaded patch set 3 07/25/22, 21:54

  4. Jochen Roth uploaded patch set 4 07/25/22, 22:08

  5. Jochen Roth uploaded patch set 5 07/25/22, 22:24

  6. Jochen Roth uploaded patch set 6 07/25/22, 22:31

  7. Jochen Roth uploaded patch set 7 08/03/22, 07:48

  8. Jochen Roth uploaded patch set 8 08/05/22, 18:02

  9. Jochen Roth uploaded patch set 9 08/05/22, 21:50

  10. Jochen Roth wrote 12/21/22, 04:48

    Unset private
  11. Jochen Roth uploaded patch set 10 02/01/23, 10:49

  12. core-ci voted on patch set 10 V -1 02/01/23, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36863

  13. Jochen Roth uploaded patch set 11 V -1 02/01/23, 17:06

  14. core-ci voted on patch set 11 V -1 02/01/23, 17:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36895

  15. Jochen Roth uploaded patch set 12 V -1 02/02/23, 11:53

  16. core-ci voted on patch set 12 V -1 02/02/23, 13:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36919

  17. Jochen Roth uploaded patch set 13 V -1 02/04/23, 21:23

  18. Jochen Roth uploaded patch set 14 02/04/23, 21:43

  19. core-ci voted on patch set 13 V -1 02/04/23, 21:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37071

  20. core-ci voted on patch set 14 V -1 02/04/23, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37072

  21. Jochen Roth uploaded patch set 15 V -1 02/05/23, 16:31

  22. core-ci voted on patch set 15 V -1 02/05/23, 17:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37120

  23. Jochen Roth commented on patch set 15 02/06/23, 15:48

    This change is ready for review.
    As it is it will not make it into the core. When a element with relations was deleted, it causes a lot of issues on the client side removal. Basically leaving a inconsistent dom.
  24. Jochen Roth marked it work in progress 02/06/23, 15:48

  25. Jochen Roth abandoned the change 07/15/26, 10:27