Review main Merged

75244[TASK] Remove superfluous variable initialization in TypoScriptParser

Torben Hansen CR +2 V +2 Easy +0 −1 updated 07/19/22, 18:06

Commit message

The initialization of the variable `$conditionMatcher` with a
`null` value can safely be removed, since the following condition
always overwrites the initial variable value.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Torben Hansen uploaded patch set 1 07/19/22, 16:36

  2. core-ci voted on patch set 1 V +1 07/19/22, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29360

  3. Torben Hansen updated the commit message in patch set 2 07/19/22, 16:48

  4. Nikita Hovratov voted on patch set 2 V +1 CR +1 07/19/22, 16:50

  5. core-ci voted on patch set 2 V +1 07/19/22, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29361

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 07/19/22, 18:06

  7. Christian Kuhn merged patch set 3 07/19/22, 18:06