Review main Merged

75249[BUGFIX] Fix dead code path in LanguageService

crell CR +2 V +2 Easy +1 −6 updated 07/21/22, 05:53

Commit message

This check likely predates types being specified, which
makes it unnecessary.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. crell uploaded patch set 1 07/20/22, 16:24

  2. core-ci voted on patch set 1 V +1 07/20/22, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29381

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 07/20/22, 19:38

  4. Stefan Bürk updated the commit message in patch set 2 07/20/22, 20:45

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 07/20/22, 20:46

  6. core-ci voted on patch set 2 V +1 07/20/22, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29383

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 07/21/22, 05:53

  8. Andreas Kienast merged patch set 3 07/21/22, 05:53