75250[TASK] Replace btn-checkbox usages with form-check
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Andreas Kienast +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/Sass/component/_checkbox.scss+16 −0
- Build/Sources/Sass/typo3/_element_buttons.scss+0 −28
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+10 −3
- typo3/sysext/tstemplate/Classes/Controller/ConstantEditorController.php+19 −9
Review log 710
-
Andreas Kienast uploaded patch set 1 07/20/22, 19:35
-
core-ci voted on patch set 1 V +1 07/20/22, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29382
-
Nikita Hovratov commented on patch set 1 V +1 CR +1 07/22/22, 09:03
In the translation overview this looks ok, I would say. In the constants editor however, I'm not sure if one would recognize this as a checkbox right away, because it is like glued together with the reverse button. This is furthermore worsended by the fact, that there is no hover effect for checkboxes. We really should consider adding a cursor at least for all checkboxes here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75127 Can be done afterwards, though. -
Andreas Kienast uploaded patch set 2 07/22/22, 10:23
-
core-ci voted on patch set 2 V +1 07/22/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29418
-
Andreas Kienast uploaded patch set 3 07/22/22, 10:48
-
Nikita Hovratov voted on patch set 3 V +1 CR +1 07/22/22, 10:53
-
core-ci voted on patch set 3 V +1 07/22/22, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29419
-
Andreas Kienast voted on patch set 3 V +2 CR +2 07/22/22, 11:50
-
Andreas Kienast merged patch set 4 07/22/22, 11:50