Review main Merged

75250[TASK] Replace btn-checkbox usages with form-check

Andreas Kienast CR +2 V +2 Normal +46 −41 updated 07/22/22, 11:50

Commit message

There were a few usages of `btn-checkbox` left in TYPO3 code base which
can be savely replaced with Bootstrap's `form-check`.

To make it more recognizable in the constants editor, the unchecked
state is represented by a square icon, representing an unchecked box.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Andreas Kienast uploaded patch set 1 07/20/22, 19:35

  2. core-ci voted on patch set 1 V +1 07/20/22, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29382

  3. Nikita Hovratov commented on patch set 1 V +1 CR +1 07/22/22, 09:03

    In the translation overview this looks ok, I would say. In the constants editor however, I'm not sure if one would recognize this as a checkbox right away, because it is like glued together with the reverse button. This is furthermore worsended by the fact, that there is no hover effect for checkboxes. We really should consider adding a cursor at least for all checkboxes here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75127 Can be done afterwards, though.
  4. Andreas Kienast uploaded patch set 2 07/22/22, 10:23

  5. core-ci voted on patch set 2 V +1 07/22/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29418

  6. Andreas Kienast uploaded patch set 3 07/22/22, 10:48

  7. Nikita Hovratov voted on patch set 3 V +1 CR +1 07/22/22, 10:53

  8. core-ci voted on patch set 3 V +1 07/22/22, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29419

  9. Andreas Kienast voted on patch set 3 V +2 CR +2 07/22/22, 11:50

  10. Andreas Kienast merged patch set 4 07/22/22, 11:50