Review 11.5 Merged

75252[BUGFIX] Fix dead code path in LanguageService

Andreas Kienast CR +2 V +2 Easy +1 −6 updated 07/21/22, 06:17

Commit message

This check likely predates types being specified, which
makes it unnecessary.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Andreas Kienast uploaded patch set 1 07/21/22, 06:01

  2. Andreas Kienast updated the commit message in patch set 2 07/21/22, 06:02

  3. core-ci voted on patch set 1 V +1 07/21/22, 06:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29392

  4. core-ci voted on patch set 2 V +1 07/21/22, 06:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29393

  5. Andreas Kienast voted on patch set 2 V +2 CR +2 07/21/22, 06:17

  6. Andreas Kienast merged patch set 3 07/21/22, 06:17