Review main Merged

75253[BUGFIX] Fix PHP 8 array access in BackendUtility

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 07/21/22, 08:58

Commit message

When the TCA colon feature for ['ctrl']['type'] is
used in inline parent child relations, the target
record may not yet be persisted and getRecord()
returns null.

This triggers a PHP 8 array warning.
Sanitize this access.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Michael Semle +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Michael Semle +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 07/21/22, 08:39

  2. Christian Kuhn updated the commit message in patch set 2 07/21/22, 08:39

  3. Michael Semle voted on patch set 2 V +1 CR +1 07/21/22, 08:42

  4. core-ci voted on patch set 2 V +1 07/21/22, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29396

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 07/21/22, 08:47

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 07/21/22, 08:48

  7. Christian Kuhn merged patch set 3 07/21/22, 08:58