Review main Merged

75264[TASK] Correct incomplete doc types

crell CR +2 V +2 Easy +1 −13 updated 07/26/22, 21:02

Commit message

ExtensionStatus::getStatus()'s doc type does not account for
the use of [] as a sentinel value.

The extra doc type declaration in
FolderBasedFileCollection::fromArray() is incorrect, as it
does not account for null return values.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1722

  1. crell uploaded patch set 1 07/22/22, 18:17

  2. core-ci voted on patch set 1 V +1 07/22/22, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29433

  3. Oliver Klee commented on patch set 1 07/22/22, 19:02

    FolderBasedFileCollection.php:118

    We can also completely drop the type annotation as the method already has this return type declaration.
  4. crell uploaded patch set 2 07/22/22, 19:54

  5. crell commented on patch set 1 07/22/22, 19:54

    FolderBasedFileCollection.php:118 Reply

    Ack
  6. core-ci voted on patch set 2 V +1 07/22/22, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29437

  7. Oliver Klee voted on patch set 2 CR +1 07/22/22, 21:57

  8. Oliver Hader updated the commit message in patch set 3 07/23/22, 08:57

  9. Oliver Hader voted on patch set 3 CR +1 07/23/22, 08:57

  10. Oliver Klee voted on patch set 3 CR +1 07/23/22, 09:01

  11. core-ci voted on patch set 3 V +1 07/23/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29447

  12. Stefan Bürk commented on patch set 3 07/25/22, 20:38

    Commit message is not correct/precise enough: * only one method doc block is adjusted (singular, not plural) * one annotation comment is removed
  13. Stefan Bürk commented on patch set 3 07/25/22, 20:40

    Reply

    Missing "used command" for phpstan command
  14. crell updated the commit message in patch set 4 07/25/22, 21:56

  15. crell commented on patch set 4 07/25/22, 21:56

    Reply

    Done
  16. Oliver Klee voted on patch set 4 CR +1 07/25/22, 22:15

  17. core-ci voted on patch set 4 V +1 07/25/22, 23:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29524

  18. Christian Kuhn updated the commit message in patch set 5 07/26/22, 20:42

  19. core-ci voted on patch set 5 V +1 07/26/22, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29582

  20. Christian Kuhn voted on patch set 5 V +1 CR +1 07/26/22, 21:02

  21. Stefan Bürk voted on patch set 5 V +2 CR +2 07/26/22, 21:02

  22. Stefan Bürk merged patch set 6 07/26/22, 21:02