Review main Merged

75266[TASK] Make ImageProcessingService strictly typed

crell CR +2 V +2 Easy +6 −27 updated 07/26/22, 21:32

Commit message

Also switches to constructor property promotion in the process.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. crell uploaded patch set 1 07/22/22, 20:27

  2. core-ci voted on patch set 1 V +1 07/22/22, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29438

  3. Chris Müller commented on patch set 1 CR -1 07/23/22, 07:04

    Should only go into main. v11.5 supports PHP 7.4 which does not have constructor property promotion.
  4. crell updated the commit message in patch set 2 07/25/22, 15:25

  5. crell commented on patch set 2 07/25/22, 15:25

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 07/25/22, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29504

  7. Stefan Bürk updated the commit message in patch set 3 07/25/22, 19:50

  8. core-ci voted on patch set 3 V +1 07/25/22, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29511

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 07/25/22, 20:06

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 07/26/22, 21:32

  11. Christian Kuhn merged patch set 4 07/26/22, 21:32