Review main Merged

75268[TASK] Make DatabaseTreeDataProvider strictly typed

crell CR +2 V +2 Normal +46 −108 updated 07/31/22, 11:08

Commit message

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2733

Show 68 earlier messages
  1. crell uploaded patch set 1 07/22/22, 21:14

  2. core-ci voted on patch set 1 V +1 07/22/22, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29440

  3. Oliver Hader marked it work in progress 07/23/22, 08:59

  4. Oliver Hader commented on patch set 1 07/23/22, 09:00

    Please include properties as well if it "likely could be [done]"
  5. crell uploaded patch set 2 07/25/22, 15:24

  6. crell marked it ready for review 07/25/22, 15:24

  7. core-ci voted on patch set 2 V +1 07/25/22, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29503

  8. Stefan Bürk commented on patch set 2 07/25/22, 19:47

    DatabaseTreeDataProvider.php:205

    Should be `?DatabaseTreeNode`
  1. crell uploaded patch set 3 07/25/22, 21:51

  2. crell commented on patch set 3 07/25/22, 21:52

    DatabaseTreeDataProvider.php:205 Reply

    Ack
  3. Oliver Klee commented on patch set 3 07/25/22, 21:57

    DatabaseTreeDataProvider.php:53

    /** * @var self::MODE_* */

    DatabaseTreeDataProvider.php:137

    @param self::MODE_* $lookupMode (We might need additional type annotations in the callers for this.)

    DatabaseTreeDataProvider.php:145

    @return self::MODE_*
  4. crell uploaded patch set 4 07/25/22, 22:36

  5. crell commented on patch set 3 07/25/22, 22:36

    DatabaseTreeDataProvider.php:53 Reply

    Done

    DatabaseTreeDataProvider.php:137 Reply

    Local testing says it's fine with just the changes here.

    DatabaseTreeDataProvider.php:145 Reply

    Done
  6. core-ci voted on patch set 3 V +1 07/25/22, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29523

  7. core-ci voted on patch set 4 V +1 07/25/22, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29527

  8. Oliver Klee voted on patch set 4 CR +1 07/26/22, 09:29

  9. crell uploaded patch set 5 07/27/22, 14:16

  10. core-ci voted on patch set 5 V +1 07/27/22, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29618

  11. Oliver Hader voted on patch set 5 CR +1 07/27/22, 14:55

  12. Simon Schaufelberger voted on patch set 5 CR +1 07/29/22, 01:14

  13. Georg Ringer commented on patch set 5 CR -1 07/29/22, 06:27

    Breaking-97210-TypesAddedToMethodSignaturesOrClassProperties.rst:17

    IMO it should be - :php:`\TYPO3\CMS\Core\Tree\TableConfiguration\DatabaseTreeDataProvider`
  14. Simon Schaufelberger voted on patch set 5 CR -1 07/29/22, 09:19

  15. Stefan Bürk commented on patch set 5 07/30/22, 22:19

    Simon, can you please explain your -1 ?
  16. Stefan Bürk uploaded patch set 6 07/30/22, 22:21

  17. Stefan Bürk commented on patch set 6 07/30/22, 22:22

    Breaking-97210-TypesAddedToMethodSignaturesOrClassProperties.rst:17 Reply

    Done
  18. core-ci voted on patch set 6 V +1 07/30/22, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29731

  19. Simon Schaufelberger commented on patch set 6 07/30/22, 22:31

    Reply

    I just wanted to revert my +1 and confirm what Georg found.
  20. Simon Schaufelberger voted on patch set 6 CR +1 07/30/22, 22:32

  21. Simon Schaufelberger commented on patch set 6 07/30/22, 22:33

    Reply

    Done
  22. Stefan Bürk voted on patch set 6 V +1 CR +1 07/30/22, 22:33

  23. Oliver Klee voted on patch set 6 CR +1 07/31/22, 07:58

  24. Christian Kuhn voted on patch set 6 V +2 CR +2 07/31/22, 11:08

  25. Christian Kuhn merged patch set 7 07/31/22, 11:08