Review main Abandoned

75285[BUGFIX] Correct int consts used with PropertyMappingConfiguration

crell CR 0 V 0 Normal +8 −85 updated 07/04/23, 20:24

Commit message

Although the code is technically working at present, the interface
explicitly expects a string key, not an int. This patch ensures
it always gets a string.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 59

  1. crell uploaded patch set 1 07/25/22, 16:48

  2. core-ci voted on patch set 1 V +1 07/25/22, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29505

  3. crell updated the commit message in patch set 2 07/25/22, 21:33

  4. crell updated the commit message in patch set 3 07/25/22, 21:34

  5. core-ci voted on patch set 2 V +1 07/25/22, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29519

  6. core-ci voted on patch set 3 V +1 07/25/22, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29520

  7. Benni Mack updated the commit message in patch set 4 V +1 05/03/23, 09:20

  8. core-ci voted on patch set 4 V -1 05/03/23, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41395

  9. Benni Mack abandoned the change 07/04/23, 20:24

    will abandon this change now due to lack of activity, can be restored later-on