Review main Merged

75295[TASK] Flesh out type declarations in PropertyMapper

crell CR +2 V +2 Easy +8 −42 updated 08/19/22, 09:13

Commit message

Doing so allows us to remove an unnecessary test, as well.

'mixed' type declarations not included to allow backporting.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1721

  1. crell uploaded patch set 1 07/26/22, 18:26

  2. core-ci voted on patch set 1 V +1 07/26/22, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29565

  3. Simon Schaufelberger updated the commit message in patch set 2 07/29/22, 01:09

  4. core-ci voted on patch set 2 V +1 07/29/22, 01:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29674

  5. Alexander Schnitzler commented on patch set 2 07/31/22, 12:54

    PropertyMapper.php:177

    This is no longer necessary.

    PropertyMapper.php:218

    Not sure what's the current rule in the core team but those comments no longer hold any important information. Last time I was quite active (pre pandemic), we usually removed those.
  6. Stefan Bürk commented on patch set 2 07/31/22, 19:47

    PropertyMapper.php:218 Reply

    That's still the same. If doctype argument and return type does not have any valueable information to it and it is native typed, it can be removed (and should). At least if it is kind of related and the patch does soemthing in that area, the one or other side change is still okay.
  7. crell commented on patch set 2 08/01/22, 18:02

    PropertyMapper.php:177 Reply

    Done

    PropertyMapper.php:218 Reply

    Done
  8. Simon Schaufelberger voted on patch set 2 CR +1 08/01/22, 18:35

  9. Alexander Schnitzler commented on patch set 2 08/03/22, 17:40

    PropertyMapper.php:177 Reply

    How is this done? There is no new patch set.

    PropertyMapper.php:218 Reply

    How is this done? There is no new patch set.
  10. crell commented on patch set 2 08/03/22, 17:58

    PropertyMapper.php:177 Reply

    I hit done, then went to push, and I'm having trouble with Git authentication I discovered when I went to push. :-( Not sure why yet. Still trying to figure it out.
  11. crell uploaded patch set 3 08/04/22, 20:44

  12. core-ci voted on patch set 3 V +1 08/04/22, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29823

  13. crell commented on patch set 3 08/05/22, 15:27

    PropertyMapper.php:177 Reply

    Now resolved.

    PropertyMapper.php:218 Reply

    Done
  14. Moritz Ngo voted on patch set 3 CR +1 08/05/22, 21:07

  15. Alexander Schnitzler voted on patch set 3 V +1 CR +1 08/08/22, 10:58

  16. Christian Kuhn updated the commit message in patch set 4 08/19/22, 08:25

  17. Christian Kuhn commented on patch set 4 V +1 CR +1 08/19/22, 08:26

    i would like to start avoiding backporting things like this to v11 and removed it from then list.
  18. Stefan Bürk commented on patch set 4 V +1 CR +1 08/19/22, 08:27

    Reply

    ack.
  19. core-ci voted on patch set 4 V +1 08/19/22, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30294

  20. Christian Kuhn voted on patch set 4 V +2 CR +2 08/19/22, 09:12

  21. Christian Kuhn merged patch set 5 08/19/22, 09:13