Review 11.5 Merged

75302[TASK] Correct incomplete doc types

Christian Kuhn CR +2 V +2 Easy +1 −13 updated 07/26/22, 21:04

Commit message

ExtensionStatus::getStatus()'s doc type does not account for
the use of [] as a sentinel value.

The extra doc type declaration in
FolderBasedFileCollection::fromArray() is incorrect, as it
does not account for null return values.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Christian Kuhn uploaded patch set 1 07/26/22, 20:43

  2. core-ci voted on patch set 1 V +1 07/26/22, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29583

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 07/26/22, 21:04

  4. Stefan Bürk merged patch set 2 07/26/22, 21:04