Review 11.5 Merged

75303[BUGFIX] Correct bad doc type in QueryObjectModelFactory

Christian Kuhn CR +2 V +2 Easy +2 −7 updated 07/26/22, 21:04

Commit message

The docblock for QueryObjectModelFactory::comparison() expects
a string, specifically one of the QueryObjectModelConstants.JCR_OPERATOR_*
constants.  However, that class seems to no longer exist,
and what it actually uses is an integer. (Passing a string through
would break in subsequent sub-calls.)

This corrects the type to the correct integer constants that
are actually used in practice, and uses a language type
to ensure it is used properly.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2