Review main Merged Breaking

75310[!!!][TASK] Resolve most #[ReturnTypeWillChange] attributes

crell CR +2 V +2 Hard +101 −242 updated 09/26/22, 14:56

Commit message

Sets return types for most classes that implement
PHP SPL classes. Only "mixed" return types are not
set: That would be hard breaking for extensions
that support both core v11 and v12, since it is not
PHP 7.4 compatible. Those places are marked with
an @todo to switch to mixed in v13.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 21