Review main Merged

75311[BUGFIX] Add sys_language_uid for PageSlugCandidateProvider

Benni Mack CR +2 V +2 Easy +1 −1 updated 07/28/22, 18:03

Commit message

When using routing and custom enhancers to find out
what page translation was exactly used to build
special logic for Page resolving, the two
language-related properties "sys_language_uid"
and "l18n_cfg" are now loaded (and thus, added to the
"_page" property of a Route) as well.

This is useful as l10n_parent is already loaded anyways.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack uploaded patch set 1 07/27/22, 11:12

  2. core-ci voted on patch set 1 V +1 07/27/22, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29607

  3. Benni Mack updated the commit message in patch set 2 07/28/22, 10:46

  4. core-ci voted on patch set 2 V +1 07/28/22, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29631

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 07/28/22, 17:21

  6. Georg Ringer voted on patch set 2 V +2 CR +2 07/28/22, 18:03

  7. Georg Ringer merged patch set 3 07/28/22, 18:03