Review main Merged

75313[TASK] Avoid setting undefined property in test case

Stefan Bürk CR +2 V +2 Easy +0 −3 updated 07/27/22, 12:17

Commit message

With PHP 8.2 setting undefined properties in class
instances is deprecated and emits corresponding
deprecation notice.

This patch removes a superflous test, setting a
undefiend property in `TypoScriptFrontendController`
to avoid PHP 8.2 deprecation message.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 07/27/22, 11:33

  2. core-ci voted on patch set 1 V +1 07/27/22, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29611

  3. Oliver Klee voted on patch set 1 CR +1 07/27/22, 11:47

  4. Oliver Klee voted on patch set 1 V +1 07/27/22, 11:48

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 07/27/22, 12:17

  6. Christian Kuhn merged patch set 2 07/27/22, 12:17