Review main Merged

75315[BUGFIX] indexed_search: PHP 8 array key exists check

Daniel Hettler CR +2 V +2 Easy +2 −2 updated 07/28/22, 12:52

Commit message

Another PHP 8 sanitation checking for array
key existance.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Daniel Hettler uploaded patch set 1 07/27/22, 15:12

  2. core-ci voted on patch set 1 V +1 07/27/22, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29623

  3. Oliver Klee voted on patch set 1 CR +1 07/27/22, 16:23

  4. Christian Kuhn commented on patch set 1 07/27/22, 16:24

    this would be shorter and a bit more elegant using ?? operator.
  5. Christian Kuhn uploaded patch set 2 07/27/22, 16:27

  6. Christian Kuhn commented on patch set 2 V +1 CR +1 07/27/22, 16:27

    I think this variant is a bit more concise. What do you think?
  7. Christian Kuhn updated the commit message in patch set 3 07/27/22, 16:28

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 07/27/22, 16:29

  9. Oliver Klee voted on patch set 3 CR +1 07/27/22, 16:33

  10. core-ci voted on patch set 3 V +1 07/27/22, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29626

  11. core-ci voted on patch set 2 V +1 07/27/22, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29625

  12. Nikita Hovratov voted on patch set 3 V +1 CR +1 07/27/22, 19:03

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 07/28/22, 12:51

  14. Christian Kuhn merged patch set 4 07/28/22, 12:52