Review main Merged

75317[TASK] Upgrade to codeception/codeception 5.x

Stefan Bürk CR +2 V +2 Hard +300 −199 updated 07/31/22, 10:58

Commit message

Codeception released new major version 5, which
unblocks upgrading to symfony 6 components.
This patch raises codeception only, thus acting as a
pre-patch to raise symfony requirements.

Codeception 5 is hard to impossible with core v11,
so this patch is v12 only: Codeception 5 requires
PHP 8.0, so we'd have to support both 4 and 5 in
v11 to allow testing with older PHP versions. This
would result in various headaches since some API
changes in codeception 5 are hard breaking in PHP,
especially due to changed class property type hints.
We'll thus keep codeception 4 in v11 and go with
codeception 5 in v12.

Minor acceptance test related adaptions are needed:

* Replaced config option `path.log` with `path.output`
* Added proper property type because of inheritance to
  codeception setup classes
* Ensure method return type compatibility
* Use `actor`instead of `class name` in suite config
* Create acceptance split files in proper folder to
  ensure group filtering keeps working. Adjust clean
  up scripts and gitignore for this

Used commands:

> composer req --dev -w \
  typo3/testing-framework:dev-main \
  codeception/codeception:^5.0.0 \
  codeception/module-asserts:^3.0.0 \
  codeception/module-cli:^2.0.0 \
  codeception/module-filesystem:^3.0.0 \
  codeception/module-webdriver:^3.1.2 \
  codeception/lib-asserts:^2.0.0

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9